[Kde-pim] KDE/kdepim/korganizer

[Marc Mutz]

On Tuesday March 4 2008 12:00, Marijn Kruisselbrink wrote:
> David Faure wrote:
> > On Tuesday 04 March 2008, Marc Mutz wrote:
> >> On Monday March 3 2008 17:12, Thomas McGuire wrote:
> >>> Are you aware of any BIC commits?
> >>
> >> Come to think of it, I'm not sure
> >>
> >> - class Attendee : public Person
> >> + class Attendee : private Person
> >>  {
> >> + using Person::email;
> >> + using Person::setEmail;
> >> + ...
> >>
> >> is BC on all compilers. Does anyone know? The vtable layout at least
> >> shouldn't change, but some compilers encode access protection in the
> >> mangled names, but I doubt they do that for base classes, too.
> >
> > I thought only MSVC encoded access protection into mangled names,
> > and we don't have BC requirements for MSVC yet anyway.
>
> Isn't it not even source compatible? From this snippet it appears
> previously you could do stuff like Person* p = new Attendee(..), which
> now no longer is allowed?
<snip>

Right, but that conversion was used nowhere in-tree, and it was dangerous to 
begin with (Person has a non-virtual dtor).

Thanks,
Marc

-- 
Marc Mutz - marc at kdab.com, mutz at kde.org - Klarälvdalens Datakonsult AB
Platform-independent software solutions - www.kdab.com info at kdab.com
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/