[Kde-pim] [patch] smale patch for server/src/storage/dbinitializer.cpp (pSQL-support and some mysql-stuff)

[Volker Krause]

On Friday 28 March 2008 22:47:02 Tony Wolf wrote:
> I've done my second patch on
> akonadi/server/src/storage/dbinitializer.cpp. It provides some chances
> for PSQL support as requested on [1].
>
> It compiles and seems to work. I started akonadiserver, once without db
> and once with already existing db. Also I import a ical-resouce.
>
> Also I delete
>
> while ( query.next() ) {
>      // FIXME: use column name (key_name) instead of column index!!
>      if ( query.value(2) == indexName )
>        return true;
>    }
>
> and source it out in the sql-statement (both, MySQL and PSQL).
>
> Please review it as I try to match your coding-style. I hope, that I
> haven't forgot a rule. :D

Thanks! Committed with minimal changes (LIKE -> = in MySQL index query, 
missing spaces in second line of hasIndex()).

I agree with Jaroslaw that if we want to support multiple database backends we 
should rather add an abstraction layer instead of spreading these conditions 
all over the code.

regards
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080329/d5109db5/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/