[Kde-pim] External editor in kmail

[Thomas McGuire]

Hi,

On Monday 16 June 2008 21:18:01 Jakub Stachowski wrote:
> Hello,
>
> Attached is a patch that fixes external editor for kmail ( bug 162279 ). It
> would be nice to have it working for next beta, so please review.
> One thing I am not sure about: mail contents is written to temporary file (
> to be later edited with external editor and pulled back into kmeditor ) as
> UTF-8.
> Do we still care about editors without utf support?
Thanks for the patch, seems to work fine. Please commit (although I think 
we're in the tagging freeze for Beta2 already, so you might need to wait a 
bit).

Does this fix https://bugs.kde.org/show_bug.cgi?id=109067 as well? If so, 
please close that.

Just two small things:
1. If you use setTextOrHtml() [1] instead of setPlaintext(), then the user 
   could even start a WYSIWYG HTML editor.
   This is https://bugs.kde.org/show_bug.cgi?id=148743 . Note I didn't test 
   it, but it might just work.

2. Minor style issues like no spaces around parenthesis or a two long connect 
   line

[1] http://api.kde.org/4.x-api/kdelibs-
apidocs/kdeui/html/classKRichTextEdit.html#6c27d637c8924530a07d6a50eda7a8ff

Thanks,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080617/d2e11e38/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/