[Kde-pim] documentation in FindKdePimLibs.cmake missing

[Allen Winter]

On Sunday 20 July 2008 05:58:10 Alexander Neundorf wrote:
> Hi,
> 
> I just had a look at FindKdepimLibs.cmake and noticed that the variables it 
> defines (all the KDE4_*_LIBS and KDE4_*_LIBRARY variables) are undocumented.
> Can you please add them at the top of the file, similar to how it is done in 
> FindKDE4Internal.cmake ?
> 
> A second note: I think it is a bit strange that the library variables coming 
> from FindKdepimLibs.cmake use the KDE4_ prefix, I think it would be better if 
> they would use something like KDEPIMLIBS_ or KDEPIM_ as prefix. This would 
> make it clear 
> -that they belong to kdepim
> -that I don't have to search in FindKDE4Internal.cmake to find them
> 
> It's a bit late to change that now, but at least compatibility variables can 
> still be added.
> So additionally to the KDE4_ variables you could add KDEPIM_ variables:
> set(KDEPIM_AKONADI_LIBRARY ${KDE4_AKONADI_LIBRARY} )
> 
> What do you think about this ? Objections ?
> 
Sounds like the right thing to me.
Alex, can you take care of this or do you want a kdepim person to tackle it?

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/