[Kde-pim] [patch] Printing emails

[Ingo Klöcker]

On Monday 07 July 2008, Jaroslaw Staniek wrote:
> Possible fix for [1] (Windows).
> For review.
>
> The code (before patching) works on Linux (?) only by accident, I
> guess (probably thanks to different strategy of handling QTimers with
> 0 delay [2]).
>
> Explanation: KMReaderWin::printMsg() _can_ be executed before the
> timer handling slotWriteNextHtmlChunk() finishes. And it is, on
> Windows. Another place where usign timers looks unfortunate..
>
> [1] http://intevation.de/roundup/kolab/issue2647
> [2] mHtmlTimer.start( 0 );

The correct fix would be making sure that printMsg() is not called 
before writting the HTML is finished (probably by introducing a new 
signal and listening to it). I'm not sure your patch is a good fix 
since it is clearly against the intent of KHtmlPartHtmlWriter to write 
the full queue synchronously to the HTML part. Since Marc wrote this 
class I hope he will comment on this.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080708/cca3b8e1/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/