[Kde-pim] RC1 Deadline Extended for KDEPIM ONLY

[Thomas McGuire]

Hi,

On Tuesday 08 July 2008 22:29:21 Allen Winter wrote:
> Howdy,
>
> For KDE-PIM ONLY:
>
> The Release Team is extending the RC1 deadline until Thursday midnight UTC.
OK, my KMail bug (http://bugs.kde.org/show_bug.cgi?id=166077) turned out to be 
not such a big issue.
It turned out that I've fixed the dataloss itself in r816901 (see 
http://websvn.kde.org/?view=rev&revision=816901).
I had idiotic local modifications today (actually to track the cause down), 
which re-triggered the dataloss... So no dataloss problem with the trunk 
version.

Now, there's just one problem left: If the filtering stops because the move 
failed, filtering will on IMAP will not work again until KMail is restarted.

The attached patch fixes that by not returning in finish() in case of an 
error. This will allow to reach the cleanup block at the end of the function 
which resets the locks.
Additionally, the patch fixes a problem in moveMessageFinished(): The 
scheduler would not advance to the next stage properly if the moving failed 
(which it does in case of GMail).

I would appreciate a review of the patch, but I don't risk to apply this 
before the release in any case.

As for filtering with GMail, that wil simply remain broken, but there's a 
kWarning() about that. Fixing that is not easily possible:
GMail prevents duplicate messages, so we would need to delete the original 
message before moving the message from the temporary filter folder back to the 
IMAP inbox. This however would open a window where all kinds of things can go 
wrong and cause message loss. The other solution would be to add a space to 
the end of the subject when filtering, to fool GMail's duplicate detection, 
but that turned out to be difficult because mimelib seems to strip spaces and 
I didn't want to dive into that.

The problems mentioned above are just smallish problems, I think tagging RC1 
can go ahead.

Regards,
Thomas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: actionscheduler.diff
Type: text/x-patch
Size: 6461 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080709/82484a0a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080709/82484a0a/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/