[Kde-pim] Should we switch from KDE_fseek to QT_FSEEK, etc. ? was: Re: kmail doesn't compile from trunk on Slackware GNU/Linux

[Jarosław Staniek]

Giovanni Venturi said the following, On 2008-01-24 21:33:
> Alle giovedì 24 gennaio 2008, Jarosław Staniek ha scritto:
>> Giovanni Venturi said the following, On 2008-01-24 15:15:
>>> Alle giovedì 24 gennaio 2008, Jarosław Staniek ha scritto:
>>>> Giovanni Venturi said the following, On 2008-01-24 14:22:
>>>>> Alle giovedì 24 gennaio 2008, Allen Winter ha scritto:
>>>>>> On Thursday 24 January 2008 05:52:24 Giovanni Venturi wrote:
>>>>>>
>>>>>> Please tell me your platform and compiler and
>>>>>> what version of glibc (if you are on a glibc system)
>>>>> GNU/Linux Slackwarre-current. Linux 2.6.23.14, gcc 4.1.2, glibc 2.7
>>>> I guees you are compiling for 64 bits?
>>> No, no. I've got a Centrino that has 3-4 years. no 64 bits.
>>>
>>>> Giovanni, KDE_fseek == fseek64 was a mistake and will be fixed - please
>>>> replace that with QT_FSEEK or fseek locally in the kmail code.
>>> Ok, and than I can't commit the fix because you intend to fix it in
>>> another way. Did I understand? :)
>> Hmm, right. Or just change to fseek() and commit - we (or juniors?) will be
>> probably inspecting all the KDE code for such functions.
> 
> 
> devel at pavilion:~/kde4-sources/trunk/kdepim> grep -r -n "fseek64" *
> devel at pavilion:~/kde4-sources/trunk/kdepim> cd ../kdepimlibs/
> devel at pavilion:~/kde4-sources/trunk/kdepimlibs> grep -r -n "fseek64" *
> devel at pavilion:~/kde4-sources/trunk/kdepimlibs> cd ../../kdelibs/
> devel at pavilion:~/kde4-sources/kdelibs> grep -r -n "fseek64" *
> kdecore/util/.svn/text-base/kde_file.h.svn-base:62:#define 
> KDE_fseek            ::fseek64
> kdecore/util/kde_file.h:62:#define KDE_fseek            ::fseek64
> 
> So I cannot commit this change into kdelibs to compile kdepim, I could lost my 
> SVN account because kdelibs is a critical point of KDE development and I 
> don't think I can do that: I'm not a core developer. Can someone find a fix 
> or talk to the right person to solve this problem?


try
  devel at pavilion:~/kde4-sources/trunk/kdepim> grep -r -n "KDE_fseek" *

I mean the commit to kdepim/kmail/.  So please change KDE_fseek .. fseek 
locally before I commit to kmail later.
KDElibs changes have to wait a bit.

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/