[Kde-pim] [PATCH] Storing of free/busy URLs in contacts

[Till Adam]

On Friday 15 February 2008 19:26:32 Steve Wolter wrote:
> Tobias Koenig schrieb:
>
> Hi Tobias,
>
> > > > > Thanks for the patch, Steve, I'll have a look at it today. :)
> > > >
> > > > Please rename the methods in the KABC code to something meaningfull.
> > >
> > > I've replaced the short RFC 2739 terms by the long ones.
> > > Patch is attached.
> >
> > Yes, much better :)
> >
> > > +    if ( ! (*it).fburi().isEmpty() ) {
> >
> >                     ^^^ shouldn't it be renamed here as well?
>
> Sorry, didn't recompile that particular directory, changed the code and
> compiled.
>
> Patch attached.

The patch looks fine to me, and like a good idea indeed. As you pointed out, th
e various resources should be adjusted to support this as well, but that can b
e done on a case by case basis. I worry slightly about the administrative side 
of this. For some sites it might be desirable to disallow this per-contact ove
rride of the main FB URL configuration, but I don't really know. Maybe those on 
this list who are administrating larger sites would care to comment?

Thanks for the patch, in any case, and sorry to be slow reviewing it, I have a 
newborn baby very happily distracting me. :)

Till

-- 
Till Adam
KDAB - platform independent software services
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/