[Kde-pim] [PATCH] Porting Akonadi to QLocalSocket/Server

[Kevin Krammer]

On Monday 18 February 2008, Tobias Koenig wrote:
> Hej,
>
> currently we have two different code paths for Akonadi, depending on
> whether it is compiled for *nix or Windows.
>
> The attached patch unifies that by using QLocalSocket/Server from Qt 4.4
> which provides a Pipe (Windows) or Unix Domain Socket (*nix) based
> communication channel.

Excellent!
I started to work on this as well but haven't had time to finish it :-/

> I'm not sure how to handle the configuration, maybe we should rename
> UnixPath to Path. (Kevin, can you take a look at it?)

I am not sure what the requirements for Windows pipe names are, so I'd rather 
have this separated into a new connection type.
There might be no difference for us since we pass both strings to the same 
class, other language/framework implementations might have implement it 
differently.

The idea behind Data/Method was to keep the option of switching between 
transports even if our current implementation does just one.
E.g. Linux can (depending on version) also do "abstract" sockets with which an 
application doesn't need a socket dir, etc.

> Also our brave Windows tester should check whether the path bonding
> works, I tried to take care of that already.
>
> Ok to commit?

From my side, generally yes. The config stuff might still be needed to be 
handled differently depending on actual type of transport, see above.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080219/ccba7e20/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/