[Kde-pim] [patch] Improved user agent string in KMail

[Allen Winter]

On Wednesday 06 February 2008 11:17:33 Jarosław Staniek wrote:
> Hello,
> For review:
>
> - use KdeSubversion package to define KMAIL_SVN_REVISION_STRING and
> KMAIL_SVN_LAST_CHANGE macros;
>
> - then use them in KMMessage::initHeader( uint )
>
> For the latter, a new KProtocolManager::userAgentForApplication() function
> is used (just commited to kdelibs trunk).
>
> Perhaps we could add an #ifdef for KDElibs 4.0.x, falling back to
>   previous setHeaderField("User-Agent", "KMail/" KMAIL_VERSION ) ?

Looks ok.

Except I'd really like to put the svn cmake stuff into a macro.
But we can do that later.

Maybe I'll work up a prototype for Alex to approve.

-Allen

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/