[Kde-pim] [PATCH] Honor local (un)subscription of top-level folders

[Volker Krause]

On Thursday 07 February 2008 21:31:30 Till Adam wrote:
> On Wednesday 06 February 2008 21:12:16 Allen Winter wrote:
> > On Wednesday 23 January 2008 10:49:02 Till Adam wrote:
> > > On Wednesday 23 January 2008 16:31:23 Volker Krause wrote:
> > > > On Tuesday 22 January 2008 00:19:53 Ingo Klöcker wrote:
> > > > > while checking whether GMail can be used as lightweight groupware
> > > > > server. I noticed that local subscription only works for
> > > > > non-top-level folders, i.e. all top-level folders were shown
> > > > > unconditionally and KMail started to sync my kde-commits folder
> > > > > (very bad idea!). The reason for this problem is that
> > > > > setHonorLocalSubscription( true ) is only called for the ListJobs
> > > > > of subfolders, but not when listing the top-level folders in the
> > > > > namespaces.
> > > > >
> > > > > The attached patch (or more precisely the second hunk) fixes the
> > > > > problem for me. Well, not completely because the inbox is still
> > > > > listed although I unsubscribed it. Is the patch correct? Should I
> > > > > commit?
> > > >
> > > > Looks good to me and works here, so please commit. I looked into the
> > > > inbox issue, but that's not easily doable I think, the inbox is
> > > > assumed to exist in various places and apparently not even retrieved
> > > > from the server (non-local unsubscription doesn't work either btw).
> > >
> > > Right, that's not possible in IMAP, it stipulates the existance of
> > > INBOX. It's not only a folder but also the incoming queue, and thus not
> > > strictly a folder.
> >
> > Patch committed to trunk.
> > Let me know if you want it backported to the 3.5 branch.
>
> Not sure, off the top of my head, but I think Volker already put it into
> enterprise, which means it should land in 3.5 shortly.

I thought so too, but apparently it was only applied to my local working copy. 
Committed to enterprise and 3.5 now.

regards
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080212/a457850a/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/