[Kde-pim] KDE/kdepimlibs/gpgme++

[Marc Mutz]

On Monday February 25 2008 12:45, Marc Mutz wrote:
> On Sunday February 24 2008 14:33, Laurent Montel wrote:
> > --- trunk/KDE/kdepimlibs/gpgme++/gpgsetownertrusteditinteractor.cpp
> > #778732:778733 @@ -42,18 +42,6 @@
> >  }
> >  
> >  GpgSetOwnerTrustEditInteractor::~GpgSetOwnerTrustEditInteractor() {}
> > -
> > -enum {
> > -    START = EditInteractor::StartState,
> > -    COMMAND,
> > -    VALUE,
> > -    REALLY_ULTIMATE,
> > -    QUIT,
> > -    SAVE,
> > -
> > -    ERROR = EditInteractor::ErrorState
> > -};
> > -
> >  const char * GpgSetOwnerTrustEditInteractor::action() const {
> >      static const char truststrings[][2] = { "1", "1", "2", "3", "4", "5"
> > };
> > --- trunk/KDE/kdepimlibs/gpgme++/gpgsetownertrusteditinteractor.h
> > #778732:778733 @@ -29,7 +29,18 @@
> >  #include <string>
> >  
> >  namespace GpgME {
> > +enum {
> > +    START = EditInteractor::StartState,
> > +    COMMAND,
> > +    VALUE,
> > +    REALLY_ULTIMATE,
> > +    QUIT,
> > +    SAVE,
> >  
> > +    ERROR = EditInteractor::ErrorState
> > +};
> > +
> > +
>
> Absolutely not acceptable. Exposes implementation details.

Only works if the .cpp's are not reordered.
Only works for two such classes.
Broke MSVC compilation.

> Please make a correct fix.
<snip>

Fixed it myself now.

On a general note, I'm _really_ getting tired of fixing almost every single 
commit to gpgme++. I encourage every committer to think at least a nanosecond 
about what the consequences are, before sending the stuff off. It also helps 
to try to understand what the problem you're trying to fix actually _is_.

Thanks,
Marc

-- 
Marc Mutz - marc at kdab.com, mutz at kde.org - Klarälvdalens Datakonsult AB
Platform-independent software solutions - www.kdab.com info at kdab.com
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/