[Kde-pim] [PATCH] fix crash in akonaid ical resource
Aaron J. Seigo
aseigo at kde.org
Thu Dec 25 06:51:04 GMT 2008
hi...
i discovered *cough* it's possible to end up with a calendar resource with no
file associated with it. the ical resource doesn't like this and crashes when
akonadi loads its resoures, particularly on line 114 of icalresource.cpp.
the attached patch fixes the crash, though i don't know if it's the preferred
fix. seems sane to my eyes, however, as mCalendar can indeed be 0 as that's
its value in the ctor.
let me know if i should commit or not =)
btw, the multi-process nature of akonadi is rather nice and robust in such
situations. i've been wanting to do the same with dataengines in plasma, and i
think i might take a crack at it in 4.3. this crash with akonadi really
underlined the practical usefulness of the approach.
merry xmas to all ..
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icalresource.diff
Type: text/x-patch
Size: 1016 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20081224/4eaace00/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20081224/4eaace00/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list