[Kde-pim] [PATCH] Akregator load favicons on first attempt

[Will Stephenson]

Hi all

Here's a fix for https://bugzilla.novell.com/show_bug.cgi?id=381498.  Favicons 
were not loaded on the first attempt, when they 
had to be fetched by the favicon service, because the favicon service emits 
iconChanged with the requested URL if the favicon was in the cache, but with 
the hostname if the favicon had to be fetched.  Since Akregator keyed pending 
requests with the URL, newly fetched favicons were not recognised in 
FeedIconManager::slotIconChanged().

I don't know why the favicon service behaves so strangely, but I have changed 
Akregator to key all pending requests on hostname, so the service' response is 
always handled.  I also fixed a QString::isNull() problem caused by DBus not 
distinguishing between a null string and an empty string.

Ok to commit or should we get to the bottom of the favicon service' behaviour?

Will


-------------- next part --------------
A non-text attachment was scrubbed...
Name: akregator_load_favicons.diff
Type: text/x-patch
Size: 1129 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080422/aeb87d25/attachment.bin>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/