[Kde-pim] [PATCH] kdepimlibs/kresources

[Kevin Krammer]

On Monday 12 November 2007, Tobias Koenig wrote:
> On Sun, Nov 11, 2007 at 09:27:47PM -0500, Allen Winter wrote:
> > On Thursday 08 November 2007 18:55:26 Kevin Krammer wrote:
>
> Hi,
>
> > Sorry.. almost overlooked this patch.

No problem, it is just a warning after all.

> > It looks good to me.  Would be happy if Tobias would also review
>
> Yes, looks good, please commit.

Thanks, committed

> > and if Tobias would also look at the warning in kdepimlibs/kabc.
>
> I'm not sure whether it is worse to keep the plugin thingy for formats
> here. It was aimed to provide a point of extensibility, however it was
> never used AFAIKS, so I'd prefer to change FormatFactory to don't load
> plugins but have them compiled in statically.

I am using a similar approach in kabcclient.
Hmm, I should have looked into this earlier, it could probably have been 
merged :(

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20071112/5a3fb44e/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/