[Kde-pim] KOrganizer4 Is Sooo Slow

[Kevin Krammer]

On Monday 05 November 2007, Allen Winter wrote:
> Howdy,
>
> Finally we know why KOrganizer is so slow.
>
> In CalendarLocal::rawEventsForDate:
>       if ( event->dtStart() <= kdt ) {
>         KDateTime end( event->dtEnd().toTimeSpec( event->dtStart() ) );
>         if ( event->allDay() ) {
>           end.setDateOnly( true );
>         } else {
>           end = end.addSecs(-1);
>         }
>         if ( end >= kdt ) {
>           eventList.append( event );
>         }
>
> replaces the old code from 3.5.x:
>      if ( event->dtStart().date() <= qd && event->dateEnd() >= qd ) {
>         eventList.append( event );

Another difference is that the new code creates "kdt" on every loop iteration, 
while the old code used the passed argument "dt".

Since it is always the same it could be moved out of the loop, probably even 
made a const object.

Could be just microoptimizing, depends on how heavy the respective KDateTime 
constructor is.

Cheers,
Keivn

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20071105/d4aeba82/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/