[Kde-pim] KOrganizer4 Is Sooo Slow
David Faure
faure at kde.org
Mon Nov 5 14:26:59 GMT 2007
On Monday 05 November 2007, Allen Winter wrote:
> On Sunday 04 November 2007 20:51:16 Cornelius Schumacher wrote:
> > On Monday 05 November 2007 02:38:33 Allen Winter wrote:
> > >
> > > Finally we know why KOrganizer is so slow.
> > >
> > > In CalendarLocal::rawEventsForDate:
> > > if ( event->dtStart() <= kdt ) {
> > > KDateTime end( event->dtEnd().toTimeSpec( event->dtStart() ) );
> >
> > The toTimeSpec call looks like it could spend a lot of time. Is this actually
> > the case?
> >
> > Why don't we convert the datetimes to UTC when saving the event?
> >
> > > if ( event->allDay() ) {
> > > end.setDateOnly( true );
> > > } else {
> > > end = end.addSecs(-1);
> > > }
> > > if ( end >= kdt ) {
> > > eventList.append( event );
> > > }
> >
>
> //old code: much, much faster
> if ( event->dtStart().date() <= qd && event->dateEnd() >= qd ) {
> eventList.append( event );
> }
>
> //new code: much, much slower
> if ( event->dtStart() <= kdt && event->dtEnd() >= kdt ) {
> eventList.append( event );
> }
> where, kdt = KDateTime(qt,timespec);
So it's KDateTime::operator< which is slow? Or what does kcachegrind say?
--
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list