[Kde-pim] KMail sendMessage() DCOP call fails to add attachments

[David Jarvie]

On Saturday 05 May 2007 21:51:33 Ingo Klöcker wrote:
> On Saturday 05 May 2007 15:27, David Jarvie wrote:
> > There is a bug in the KMail sendMessage() DCOP call
> > (http://bugs.kde.org/show_bug.cgi?id=144958) whereby attachments are
> > not added to the message before being sent. This causes errors for
> > KAlarm which uses the DCOP call. The reason for the error is due to a
> > KIO job being used to access the attachment, but sendMessage()
> > doesn't wait for the job to complete before sending the message.
> >
> > I'd like to try to get this fixed for KDE 3.5.7. It could be that
> > this issue is already addressed elsewhere in KMail. If anybody could
> > give me a further pointer to such code (so as to produce a solution
> > which fits in with how KMail does things elsewhere), I'm willing to
> > look at it further and hopefully produce a patch.
>
> I don't think this situation is already addressed in KMail. I guess the
> same would happen if one added an attachment in the composer and then
> immediately clicked on the 'Send' button.

Attached is a patch which fixes the bug. It is designed to try to avoid 
messing up if more than one sendMessage() call is being processed 
simultaneously. OK to commit?

-- 
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/kalarm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmail.diff
Type: text/x-diff
Size: 6542 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070507/0aac3980/attachment.diff>
-------------- next part --------------
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/