[Kde-pim] Can I apply Patch from Bug 97925?

[Allen Winter]

On Saturday 16 June 2007 5:41:56 am Thomas McGuire wrote:
> Hi,
> 
> On Thursday 14 June 2007, Allen Winter wrote:
> > Moving this discussion to kde-pim..
> >
> > On Friday 08 June 2007 5:21:22 pm Ingo Klöcker wrote:
> > > On Friday 08 June 2007 00:39, Allen Winter wrote:
> > > > Howdy,
> > > >
> > > > Bug 97925: Add option to disable KWallet integration completely
> > > > http://bugs.kde.org/show_bug.cgi?id=97925
> > > >
> > > > Bug as a simple patch attached which uses a hidden configuration
> > > > option. This bug has 387 votes.
> > > >
> > > > Let me know if I can commit or not.
> > > > If not, it would be nice to put the reason in a bug comment.
> > >
> > > No, for trunk because the patch does not use KConfigXT for accessing the
> > > configuration option. This is my only objection against the patch.
> > >
> > > No, for the branch because ... well, you know why. I think it was
> > > yourself who told us the reason not too long ago. The KDE 3.5 branch
> > > has been feature-frozen for the rest of its lifetime.
> >
> > I discussed this with Thomas the other day.
> > Coincidentally, he is working on this issue from another angle.
> > So I plan to drop this patch, which Thomas says was incorrect anyway.
> FYI: I marked this bug as fixed for trunk, it now works as it should there. If 
> anyone is interested in backporting, the relevant commits are:
> kdelibs: 674116 and 673666 (not sure if they are needed for this exact issue)
> kdepimlibs: 673632 (can't be backported; no idea how 3.5 handles this)
> kmail: 675974, 674135
> 
> I will not backport those (unless you really really want me to), I'd rather 
> spend my time on KDE4.
> However, I'll backport more important fixes if I happen to fix them in the 
> future.
> 
Excellent.
Thanks for your work on this Thomas.

-Allen

_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/