[Kde-pim] Korn patches for RFC2047 in headers and KMail support

[Mart Kelder]

Hello Alexis (and others),

Op Fri Jun 29 2007, schreef Alexis Papadopoulos:
> Hello,
>
> I'm sending attached a set of patches for K0rn (kdepim 3.5.7) which fix the
> following issues:

Thanks for your patch.

> _ Subject and From headers are now parsed in order to fix encoding issues
> (see RFC2047). The code is taken and adapted from KMail. I will be trying
> to see if the whole thing can be arranged to use libkmime (unless you
> consider it unwise, in that case please say so :) ), because this only
> solves part of the problem.
> Indeed, by clicking VIEW EMAIL in the popup window, the whole message is
> displayed unparsed. But this at least solves the most annoying part. If
> accepted, it should close http://bugs.kde.org/show_bug.cgi?id=118625

For the headers (which are also part of the "View Email" function), the same 
function as you used for this patch can probably by used. For the rest of the 
email, KMime can be used in a way.

> _ While testing the above modifications, I realized that using my KMail
> settings didn't work for my cachedimap account. Therefore, I did a quick
> fix for that. Quick note here too. Modifications in imap_proto.h (new
> CachedImap_Protocol derived from Imap_Protocol) can be replaced by the
> following modification in kmail_proto.cpp:
> instead of:
>         if( type == "cachedimap" )
>                 return Protocols::getProto( "cachedimap" );
> insert:
>         if( type == "cachedimap" )
>                 return Protocols::getProto( "imap" );
>
> The differences between cachedimap and imap are (I think) irrelevant for
> K0rn, therefore the above works just fine.

That is right. Because CachedImap_Protocol is (almost) equal to Imap_Protocol, 
Imap_Protocol can be used instead. So except the change above, also the class 
CachedImap_Protocol isn't necessary.

> _ KMail passwords are "encrypted" (if not in KWallet) by a simple function,
> which is in K0rn but not used. Added the necessary calls. I thought that
> could break compatibility with older KMail versions, but this encryption
> method was added into KMail before 2005 (that's as far as I could go with
> websvn.kde.org). Using the version info in kmailrc could help, but I
> sincerely don't know how to do it. And if someone upgrades korn today,
> while using his kmail config file, he most certainly upgrades kmail to a
> version post august 2005 imho.

I think it is save to assume the same version of KOrn as KMail. I agree the 
patch fixes a bug when decrypting.

> Please keep in inform if something is wrong/bad, I've just started getting
> into the kmail/korn code and I'm still learning,
> Alexis

I made some minor changes (such as the one indicated above). I will add you 
(Alexis) CC to the commit log. I will commit it within a couple of days.

Regards,

Mart
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/