[Kde-pim] Need to rename a kcal class for msvc compile

[David Faure]

On Thursday 11 January 2007 22:58, Reinhold Kainhofer wrote:
> Am Don Jän 11 2007 schrieb David Faure:
> > The testcase below doesn't compile with msvc, because "Observer" inside
> > Calendar methods is interpreted as the base class (IncidenceBase::Observer)
> > instead of being interpreted as the nested Observer class.
> 
> Didn't we have that problem already a while ago? I thought someone already
> committed the rename.
> See
> http://lists.kde.org/?t=115346274200002&r=1&w=2
> http://lists.kde.org/?l=kde-pim&m=115380715229133&w=2

Damn - Pradeepto and I spent hours debugging this today :(
If only we had known/remembered... (or if only those who found the problem had committed the rename...)

> > I don't see an
> > easy workaround that would make msvc eat this, so I would like to request
> > permission to rename one of the two observer classes.
> 
> For consistency, i would rename all observers if we rename one.

Fine with me.

Pradeepto: are you doing the rename tomorrow or should I?

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/