[Kde-pim] [patch] kdepim & kdepimlibs fixes for msvc 2k3+ (and some other non-gcc compilers)

[Jaroslaw Staniek]

Marc Mutz said the following, On 2007-12-08 11:31:
> On Saturday 08 December 2007 01:42, Jarosław Staniek wrote:
>> -    mResult = GpgME::KeyListResult( 0, err );
>> +    mResult = GpgME::KeyListResult( 0, err.toErrorCode() );
>>      return err;
> 
> Please make GpgME::*Result take a GpgME::Error instead, to minimize the 
> changes to external code.

done

Also switched the toErrorCode() to:
unsigned int GpgME::Error::encodedError() const;

>> Index: libkleo/backends/chiasmus/chiasmusjob.cpp
>> ===================================================================
>> --- libkleo/backends/chiasmus/chiasmusjob.cpp   (revision 746135)
>> +++ libkleo/backends/chiasmus/chiasmusjob.cpp   (working copy)
>> @@ -103,7 +103,8 @@
>>  
>>    LaterDeleter d( this );
>>  
>> -  if ( const GpgME::Error err = setup() )
>> +  const GpgME::Error err = setup();
>> +  if ( err )
>>      return mError = err;
> 
> Veto. There must be a better way. 2k3 is pretty conforming, afair, I'm very 
> surprised it doesn't manage to compile these declarations. Please find the 
> real reason for the compiler breakage, instead of this ugly band-aid.

Reverted this change.

Problem with 'max' is now fixed in kdesupport.

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdepim2.patch.gz
Type: application/x-gzip
Size: 3006 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20071211/c878699a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdepimlibs2.patch.gz
Type: application/x-gzip
Size: 3606 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20071211/c878699a/attachment-0001.bin>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/