[Kde-pim] KMail auto-lighted icon

[Jakob Petsovits]

On Sunday, 23. December 2007, Thomas McGuire wrote:
> On Wednesday 05 December 2007, Jakob Petsovits wrote:
> > here's a slight adaption of KMSystemTray that doesn't require a
> > "kmail-light" icon to exist, but instead takes the existing icon and
> > transforms it so that it gets a bit lighter for the blue (hardcoded!
> > evil!) text to be readable. Not made transparent, as that could hurt with
> > dark backgrounds.
>
> Thanks for the patch, it works great. I commited it in rev. 751848.

Oh, cool, that's great. I really wanted to come up with those screenshots that 
Ingo asked for, but I didn't find the time for it yet. That should be 
unnecessary now, thanks for testing and committing the patch :D

> > (blah blah blah KColorScheme blah blah)
>
> I left most of these changes out of the patch I commited, as per Ingo's
> comments. I also noticed that NegativeBackground is gray, and therefore not
> suitable for the bad PGP signature color.

NegativeBackground is not gray, it can be any color (as everything that is 
taken from KColorScheme). But yeah, it's probably safer this way, I agree 
with which parts have been committed. (It's just the custom settings anyways, 
no default settings are changed with this afaik. That could probably be a 
good idea, maybe you can ask Matthew Woehlke to look at this sometime.)

> > Non-custom-colors settings are still hardcoded, and maybe that should be
> > fixed, however I am not going to work more on that particular issue.
> > Rather than that, I'll try to fix those obnoxious mail icons.
>
> Yes, please fix them. I see there are already some commited to
> kdebase-runtime, but not all (like mark mail as todo or new).
> What about the duplicate icons in /kdepim/kmail/pics, which don't work
> anyway? Could you remove them?

I wanted to wait with removing those pngs when they are not required 
anymore... but did not consider the case that they would stop functioning in 
the first place. I'll remove those icons where a replacement in the Oxygen 
theme already exists, the others should stay back there as a safeguard.
If everything else fails, we could still roll back those icons to being 
unthemable UserIcons.

Considering that Kontact is *the* killer app that I work with all the time, I 
do hope that I'm able to fix this in a nice way :)

Thanks y'all,
  Jakob
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/