[Kde-pim] korganizer doesn't save resources immediately when changed or deleted (bug 143511)

[Jason 'vanRijn' Kasper]

On Monday 02 April 2007, Reinhold Kainhofer wrote:
> Am Dienstag, 3. April 2007 schrieb Jason 'vanRijn' Kasper:
> > On Thursday 29 March 2007 07:10:19 Reinhold Kainhofer wrote:
> > > Am Donnerstag, 29. März 2007 schrieb Cornelius Schumacher:
> > > > On Thursday 29 March 2007 04:14, Reinhold Kainhofer wrote:
> > > > > Am Donnerstag, 29. März 2007 schrieb Jason 'vanRijn' Kasper:
> > > > > > I'll of course
> > > > > > ask for permission to commit before I do, but do I have your
> > > > > > agreement that this is the Right Thing To Do (TM)?  =:)
> > > > >
> > > > > the current (default) interval of 10 minutes is really too long,
> > > > > you are right. I would think that at most half a minute (or
> > > > > something like 10 seconds) should be used (yes, the current API
> > > > > doesn't support that) to make sure that not every part of a larger
> > > > > change triggers its own saving.
> > > >
> > > > Can't we just use the SaveDelayed save policy from ResourceCached by
> > > > default, which saves 15 seconds after something has changed.
> > >
> > > Ah, right, that would be a call to
> > > void ResourceCached::setSavePolicy( int i )
> > > with i=SaveDelayed in the constructor. I wonder why we don't use that
> > > already,,,
> >
> > I poked through korganizer/libkcal today and I don't see anywhere in
> > korganizer that setSavePolicy() is called.  Since you guys know this code
> > inside and out (Cornelious/Reinhold), would you have a couple of minutes
> > to either point me to the right class/method to put this in
>
> As I wrote in my previous mails, the best place would be in the constructor
> of the file resource (ResourceLocal::ResourceLocal). The other resource
> types (remote, dIMAP, etc.) work differently, so they don't suffer from
> that problem (but trying to sync them with kpilot using the
> CalendarResources will definitely crash kpilot and there is no way to
> prevent that).
>
> Cheers,
> Reinhold

Just as one last follow-up to this...  Per Reinhold's approval, I've commited 
this one-line change to ResourceLocal::init() and ResourceLocalDir::init() to 
explicitly setSavePolicy( SaveDelayed ) in both kdepim-3.5.5+ and 
branches/KDE/3.5/kdepim  This should close the data loss problem addressed in 
bug 143511.  

Thanks again Reinhold!  =:)

-- 
 -[ Jason 'vanRijn' Kasper    //  http://movingparts.net ]-
 -[ KDE PIM Developer         //  http://www.kde.org  ]-
 -[ bash fun -> :(){ :|:&};:  //  Numbers 6:22-26 ]-
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/