[Kde-pim] Fwd: deprecated calls in kdepimlibs

David Jarvie lists at astrojar.org.uk
Sat Dec 30 02:18:34 GMT 2006


On Thursday 28 December 2006 18:30, didier chagniot wrote:
> Hi,
>
> please find enclosed a diff file regarding two small
> fixes for deprecated API uses in kdepimlibs.
>
> branch: kde4 devel (trunk/kde/kdepimlibs)
> based on revision: 616250

I don't think that the change to ktnef/formatter.cpp is likely to work 
correctly. I haven't actually checked the code properly, but 
KDateTime::fromString() assumes a different default date/time string format 
from that assumed by QDateTime::fromString() as its default. Apart from that, 
have you verified that the time zone returned as default by 
KDateTime::fromString() is the appropriate one? (Again, I'm not saying that 
it's necessarily wrong - I just make the comment to ensure that you have 
thought about it properly before the change is committed.)

-- 
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/linux/kalarm.html
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/



More information about the kde-pim mailing list