bring speed back into KConfig

Jakub Stachowski qbast at go2.pl
Mon Apr 21 17:34:43 CEST 2008


Dnia poniedziałek, 21 kwietnia 2008, David Faure napisał:
> On Saturday 19 April 2008, Jakub Stachowski wrote:
> > - Whole BufferFragment class got dumped into kconfigini_p.h and is now
> > part of KConfigIniBackend
>
> You know that you don't -have- to put all the code inside the parent class,
> right?
>
> I think this would be more readable:
>
> class KConfigIniBackend : public KConfigBackend
> {
> public:
>     class BufferFragment;
>     [... existing contents...]
> };
>
> and anywhere you want (_p.h or .cpp) :
>
> class KConfigIniBackend::BufferFragment
> {
> public:
>     [...implementation, with all methods inline, like you have
> currently...] };
>
> Otherwise human-readability of the KConfigIniBackend class becomes
> difficult :)

I didn't know it actually, so thanks for the tip.

>
> Great patch, otherwise.

I see no other comments, so I'm commiting it.


More information about the Kde-optimize mailing list