kded_kssld linking with libkssl.la

[George Staikos]

On Saturday 24 July 2004 10:54, Karl Vogel wrote:
> kded_kssld explicitly links with libkssl.la (archive library), while
> libkssl is already linked into libkio.so
>
> On my system, this makes a difference:
>
> $ ls -l .libs/kded_kssld.so
> -rwxrwxr-x  1 kvo kvo 321540 Jul 24 16:00 .libs/kded_kssld.so
>
> Becomes:
>
> $ ls -l .libs/kded_kssld.so
> -rwxrwxr-x  1 kvo kvo 73220 Jul 24 16:01 .libs/kded_kssld.so
>
>
> The Fedora Core 2 binary of kded_kssld.so is also this small, so possibly
> it's caused by the KDE_EXPORT's I have in kssl, but anyway the explicit
> link isn't needed, so I don't see any reason to keep it.
>
> If somebody else can check his kded_kssld.so module, ie try:
>
> $ objdump -CT $KDEDIR/lib/kde3/kded_kssld.so | grep KSSLX509Map
>
> It will show *UND* lines if libkssl.la isn't statically linked into the
> module, else it will show .text lines.. which would be bad.

$  objdump -CT $KDEDIR/lib/kde3/kded_kssld.so | grep KSSLX509Map
00000000      DF *UND*  00000064              KSSLX509Map::KSSLX509Map(QString 
const &)
00000000      DF *UND*  00000114              KSSLX509Map::~KSSLX509Map(void)
00000000      DF *UND*  000000ac              KSSLX509Map::getValue(QString 
const &) const

> Index: Makefile.am
> ===================================================================
> RCS file: /home/kde/kdelibs/kio/misc/kssld/Makefile.am,v
> retrieving revision 1.11
> diff -u -r1.11 Makefile.am
> --- Makefile.am 3 Jun 2004 22:00:18 -0000       1.11
> +++ Makefile.am 24 Jul 2004 13:56:41 -0000
> @@ -21,7 +21,7 @@
>  kde_module_LTLIBRARIES = kded_kssld.la
>
>  kded_kssld_la_LDFLAGS = $(all_libraries) -module -avoid-version
> -kded_kssld_la_LIBADD = $(LIB_KIO) $(top_builddir)/kio/kssl/libkssl.la
> +kded_kssld_la_LIBADD = $(LIB_KIO)
>  kded_kssld_la_SOURCES = kssld.cpp kssld.skel
>
>  METASOURCES = AUTO

  Makes sense to me...

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/