[PATCH 2] Speeding up kdebug - using print member

David Faure dfaure at klaralvdalens-datakonsult.se
Fri Oct 17 12:33:45 CEST 2003


On Friday 17 October 2003 08:52, Roger Larsson wrote:
> No comments on this patch? (Updated to newest CVS)
> 
> Really three parts that are in one patch.
> 1) All pipe operators should check 'print'
> 2) We should determine if printout is wanted up front, not when most of
>    the work is done.

Looks fine to me.
The next step would be to compare kcachegrind results, to see if it's
indeed faster ;)

> 3) Better defaults

I don't see why defaults have to be changed, though. Most output should go
out by default; the kdebugrc in kdecore is there to disable some areas by default.

+  if (!kapp && (nOutput == 1))
This should use kapp->isGUIEnabled() or whatever the name is, for the method
Waldo added recently.

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions


More information about the Kde-optimize mailing list