Comparing KHTML in Quanta and Konq

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 29 May 2003 01:04, Maks Orlovich wrote:
> On Wednesday 28 May 2003 02:42 pm, Carsten Pfeiffer wrote:
> > On Wednesday 28 May 2003 19:18, Carsten Pfeiffer wrote:
> > > > I also recall doing dcop broadcasts to update history taking nearly
> > > > 12ms per process or so
> >
> > BTW, did you measure this with the history sidebar module loaded or not?
>
> Off. I am specifically referring to KonqHistoryManager::emitAddToHistory(),
> BTW. Just timed it, and with 6 Konqueror processes (but more windows), it
> took about 135ms, in fact.
>
> I'll probably try to snoop around the code that gets called for handling
> links this evening, but can't guarantee that I'll have results.

This code looks very broken. It checks for objId() == saveId in
notifyHistoryEntry() but it seems to forget that objId is only unique for a 
give dcop client and, as far as I can see, objId() will always return 
"KonqHistoryManager".

Instead, it should compare dcopClient()->appId() with dcopClient()->senderId. 
(See patch)

I also noticed that notifyHistoryEntry gets called up to 4 times for a single 
URL, probably due to caption changes or something. Not emitting 
emitAddToHistory for pending entries would help there, as would delaying the 
actual saving a little with a timer (500ms or so?).

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+1fMYN4pvrENfboIRAqvRAKCp9Ks5k1MhGJo/omhg518csfA/lQCgnONg
E8QlvKjt5xagBH6YgLCuiEU=
=5eOt
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_history.patch
Type: text/x-diff
Size: 3903 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-optimize/attachments/20030529/8b5e8f88/konq_history.bin