[PATCH/RFC] On the iconview and the speed of directory listing.

[David Faure]

On Sunday 25 May 2003 19:32, Maks Orlovich wrote:
> On Sunday 25 May 2003 01:23 pm, David Faure wrote:
> > Very verbose comment - "no iconview" never happens :)
> 
> Then why check for it in KIconViewItem::calcRect()? ;-) 
To prevent a crash, in an impossible situation, like QIconViewItem does ;)

> > Right. Should we sent qt-bugs a patch that delays
> > QIconViewItem::calcRect()? Hmm, sounds a bit difficult, the layouting
> > relies on it.
> >
> > Another idea: we could create items without a parent view (passing 0 to the
> > QIconViewItem constructor), then calling insertItem() to insert it, then
> > calling calcRect() ?
> 
> I am not sure this order will work; QIconViewItem does it the other way around 
> (calcRect() and then insertItem() ); when I tried to reverse it in there as a 
> performance experiment, it blew up rather badly. (KDesktop would run out of 
> memory). 

Oh, then what about calcRect first (but on the KIconViewItem), then insertItem?
Or does your updateItemContainer speedup mean that this isn't necessary anymore?

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions