[tested PATCH] let QString::lower() assume lower case input to avoid real_detach()

Roger Larsson kde-optimize@mail.kde.org
Fri, 24 Jan 2003 17:34:45 +0100


On Friday 24 January 2003 17:26, Harri Porten wrote:
> On Fri, 24 Jan 2003, Lubos Lunak wrote:
>=20
> > > Summary: Not worth it for upper, definitely worth it for lower.
> > > (You have to create that a temporary QString object anyway since
> > >  lower() is const, but this avoids creating a new QStringData,
> > >  and copying the strings themselves...)
> >=20
> >  If it's tested patch, you could probably send it to qt-bugs@trolltech.=
com=20
:).
>=20
> No need to. I will fix* and improve it a bit and check it into qt-copy for
> everyone to tes^H^H^Henjoy :)
>=20
> Harri.
>=20
> * I assume that you wanted a ++ somewhere in here ;)
>=20
> +          do {
> +	      c_any =3D *p;
> +	      c_wanted =3D ::lower( c_any );
> +	    }
> +	    while (c_any =3D=3D c_wanted && --l);
>=20

Yes, where did it go? And how can the version I have work.
I did some cleanups - recompiled and retested before I sent it.
I am positive that I did install too... but it was late...

/RogerL

=2D-=20
Roger Larsson
Skellefte=E5
Sweden