comments on KDE performance tips

Harri Porten kde-optimize@mail.kde.org
Sat, 18 Jan 2003 15:05:55 +0100 (CET)


On Sat, 18 Jan 2003, David Faure wrote:

> > > Nope. This calls QString::operator==, which compares the contents.
> > > Please don't confuse QString and e.g. char *.
> > > 
> > 
> > Use the source! (from qstring.cpp)
> > 
> > 	bool operator==( const QString &s1, const QString &s2 )
> > 	{
> > 	    if ( s1.unicode() == s2.unicode() )			<= HERE!
> > 		return TRUE;
> 
> I stand corrected.

To your defense: this check has been added only very recently after being
requested at least twice. I'd have to look up who applied it as I was (and
still am) against it (and denied it) without seeing any proof that it
helped the overall performance on *average* usage.

Harri.