[upd alt PATCH] Re: [PATCH] KURL optimizations

Maks Orlovich kde-optimize@mail.kde.org
Sat, 11 Jan 2003 11:39:19 -0500


On Saturday 11 January 2003 04:34 am, Roger Larsson wrote:
> My patch again, rolls back the QString_lower changes and
> add some other optimizations.
>
> I am not sure that removing KGlobal::staticQString fileProt is a win.
> But it should be faster at least the first time...
> fileProt should probably be a static const in the class...
>
> Maks, could you benchmark this?

Too close to tell it apart speed wise, since ther eis a lot of variability. So 
looks like calling ->lower() per char costs about the same as the new string 
creation. Note that I only timed the ::parse related parts, and not anything 
else.

(Ponders patching Qt lower to add some sort of a "lower!()")