Patch/Thoughts - Konqueror's history loading..

David Faure kde-optimize@mail.kde.org
Fri, 10 Jan 2003 11:01:04 +0100


=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 10 January 2003 05:30, Maks Orlovich wrote:
> Hi.. For some people, a substational part of Konqui's startup time (in or=
der=20
> of 10+%) is the loading of the history file (for some, since it obviously=
=20
> depends on the size -- some have history files <20K, other's >100K). I've=
=20
> profiled this as best as I could. The first big bottleneck is KURL parsin=
g.=20
> The attached patch fixes that (it also drops a redundant call to prettyUR=
L),=20
> by storing KURL's in the history file format (thus it introduces a new fi=
le=20
> format version; it of course continues to load the old version).=20

Glad to see that my hint (coming from kcachegrind) was followed up :)

> Thus, I am not sure of whether to commit what I have right now

I would send a patch to the maintainer so that he knows what happened to
his file format - and what to tell people who downgrade KDE and lose histor=
y :)
Carten Pfeiffer <pfeiffer@kde.org> is the maintainer of that code.

=2D --=20
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Klar=E4lvdalens Datakonsult AB, Platform-independent software solutions
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2.1 is available - http://download.kde.org/stable/koffice-1.2.1/
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+Hpng72KcVAmwbhARAgOhAJ0clTmdwyoKJFKW2mcwoAX+K7ByoQCgq4lb
evWZIOm7Z45Kf8YVb1wrGzg=3D
=3D38Ou
=2D----END PGP SIGNATURE-----