Review Request 130109: Workaround to fix PasswordDialog's focus

Lamarque Souza lamarque at kde.org
Wed May 3 15:55:54 UTC 2017



> On May 3, 2017, 10:54 a.m., Anthony Fieroni wrote:
> > kded/passworddialog.cpp, lines 140-142
> > <https://git.reviewboard.kde.org/r/130109/diff/1/?file=495604#file495604line140>
> >
> >     When you define a focusProxy you should setFocus to main dialog i.e. 
> >     pass = new PasswordDialog(this);
> >     pass->show();
> >     pass->raise();
> >     pass->setFocus();
> >     http://doc.qt.io/qt-5/qwidget.html#setFocus

That did not work here. I have changed the implementation and it seems to work now.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130109/#review103178
-----------------------------------------------------------


On May 3, 2017, 3:54 p.m., Lamarque Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130109/
> -----------------------------------------------------------
> 
> (Updated May 3, 2017, 3:54 p.m.)
> 
> 
> Review request for Network Management and Jan Grulich.
> 
> 
> Bugs: 379279
>     http://bugs.kde.org/show_bug.cgi?id=379279
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> PasswordField does not get focus in PasswordDialog. Using PasswordField::setFocus() does not work.
> 
> 
> Diffs
> -----
> 
>   kded/passworddialog.cpp 18c686f 
> 
> Diff: https://git.reviewboard.kde.org/r/130109/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lamarque Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20170503/3e7e1808/attachment.html>


More information about the kde-networkmanager mailing list