Review Request 130111: Fix crash when retrieving active connection list

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130111/#review103174
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Grulich


On Dub. 29, 2017, 3:51 odp., Lamarque Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130111/
> -----------------------------------------------------------
> 
> (Updated Dub. 29, 2017, 3:51 odp.)
> 
> 
> Review request for Network Management and Jan Grulich.
> 
> 
> Bugs: 373393
>     http://bugs.kde.org/show_bug.cgi?id=373393
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> We use const_interator in this code but findRegisteredActiveConnection() changes the list while we iterate over it.
> 
> 
> Diffs
> -----
> 
>   src/manager.cpp 050a2dc 
> 
> Diff: https://git.reviewboard.kde.org/r/130111/diff/
> 
> 
> Testing
> -------
> 
> Plasma NM still works and no crashes so far. I cannot reproduce the crash because it is intermitent.
> 
> 
> Thanks,
> 
> Lamarque Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20170502/b4a47915/attachment.html>