Review Request 129221: Minor improvements to the editor UI
Lamarque Souza
lamarque at kde.org
Thu Oct 20 13:01:35 UTC 2016
> On Oct. 20, 2016, 12:23 p.m., Lamarque Souza wrote:
> > libs/editor/settings/ui/wificonnectionwidget.ui, line 181
> > <https://git.reviewboard.kde.org/r/129221/diff/2/?file=482712#file482712line181>
> >
> > This label looks misaligned in screenshot 4. I mean, the distance between BSSID and "Restrict to device" labels is bigger than in the other cases.
>
> Jan Grulich wrote:
> That's because there are two hidden widgets, for setting band and channel, but these are hidden when the mode is set to infrastructure. I couldn't find a way how to remove the big space, even setting widget height to 0 doesn't help. I can do what I did with the IPv4 configuration and make all widgets visible, but just disabled.
I thought that would be the case. The default spacing between widgets in a QLayout is 4px, that probably explain the space between those labels. Well, that space is the same for all rows, I do not know how to solve that without adding too much code to manage the spacing between widgets in the layout ourselves.
- Lamarque
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129221/#review100172
-----------------------------------------------------------
On Oct. 20, 2016, 8:13 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129221/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 8:13 a.m.)
>
>
> Review request for Network Management, KDE Usability and Lamarque Souza.
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> + vertical spacing between all widgets set to 6px (previously only few of them had this spacing)
> + checkbox alignment according to HIG
> + correct label alignment for some VPN widgets
>
>
> Diffs
> -----
>
> libs/editor/settings/ipv4widget.cpp 2e92061
> libs/editor/settings/ipv6widget.cpp c5fa3b8
> libs/editor/settings/ui/802-1x.ui 54ae4fc
> libs/editor/settings/ui/bond.ui 1c7d1c3
> libs/editor/settings/ui/bridge.ui 61a1db6
> libs/editor/settings/ui/bt.ui 295cd9e
> libs/editor/settings/ui/cdma.ui bace7ce
> libs/editor/settings/ui/infiniband.ui a3ab450
> libs/editor/settings/ui/ipv4.ui 0aae15e
> libs/editor/settings/ui/ipv6.ui 58d0c89
> libs/editor/settings/ui/ppp.ui f53f38b
> libs/editor/settings/ui/pppoe.ui bc6ee35
> libs/editor/settings/ui/vlan.ui 1ea5bae
> libs/editor/settings/ui/wificonnectionwidget.ui 283cff4
> libs/editor/settings/ui/wifisecurity.ui 27610d0
> libs/editor/settings/ui/wiredconnectionwidget.ui c07ae7f
> vpn/iodine/iodine.ui ac92c17
> vpn/l2tp/l2tp.ui 3dedc44
> vpn/l2tp/l2tpadvanced.ui 80e333f
> vpn/l2tp/l2tpauth.ui a5de7fe
> vpn/l2tp/l2tpppp.ui 64ce2ac
> vpn/openconnect/openconnectprop.ui ed7dfde
> vpn/openswan/openswan.ui b5e107d
> vpn/openswan/openswanauth.ui aa7f626
> vpn/openvpn/openvpnadvanced.ui 24f7564
> vpn/pptp/pptpadvanced.ui dd51bc7
> vpn/pptp/pptpprop.ui 33c1e86
> vpn/ssh/sshwidget.ui 95b4b6d
> vpn/sstp/sstpadvanced.ui d198620
> vpn/sstp/sstpwidget.ui c4a0b42
> vpn/vpnc/vpnc.ui ab0ba36
> vpn/vpnc/vpncadvanced.ui 9c27f85
>
> Diff: https://git.reviewboard.kde.org/r/129221/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20161020/aa46d04a/attachment-0001.html>
More information about the kde-networkmanager
mailing list