Review Request 129212: Move password storing options into a separated combobox
Jan Grulich
jgrulich at redhat.com
Thu Oct 20 09:53:10 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129212/
-----------------------------------------------------------
(Updated Oct. 20, 2016, 9:53 a.m.)
Status
------
This change has been marked as submitted.
Review request for Network Management, KDE Usability, Albert Astals Cid, and Lamarque Souza.
Changes
-------
Submitted with commit 3a3a21e3846c95433de228957804b91bcd76c8fd by Jan Grulich to branch master.
Repository: plasma-nm
Description
-------
As discussed over email, currently the password options (Save, Not Required, Always ask) are not easy to find so we decided to move them back to separated combobox again, ecept moving the combobox below the password field with a better description.
![Example of wireless setting](https://jgrulich.fedorapeople.org/password-field-new.png)
Diffs
-----
kded/pinwidget.ui 61c95c0
libs/editor/settings/cdmawidget.cpp 309b6e6
libs/editor/settings/gsmwidget.cpp de5a7ef
libs/editor/settings/pppoewidget.cpp 1305797
libs/editor/settings/security802-1x.cpp e5f0307
libs/editor/settings/ui/802-1x.ui 54ae4fc
libs/editor/settings/ui/cdma.ui bace7ce
libs/editor/settings/ui/gsm.ui e1c729b
libs/editor/settings/ui/pppoe.ui bc6ee35
libs/editor/settings/ui/wifisecurity.ui 27610d0
libs/editor/settings/wifisecurity.cpp fc607eb
libs/editor/widgets/passwordfield.h 627d9b0
libs/editor/widgets/passwordfield.cpp 68aa3b8
vpn/iodine/iodineauth.ui 1dcee23
vpn/l2tp/l2tp.ui 3dedc44
vpn/l2tp/l2tpauth.ui a5de7fe
vpn/openconnect/openconnectauth.cpp 1602fb8
vpn/openswan/openswan.ui b5e107d
vpn/openswan/openswanauth.ui aa7f626
vpn/openvpn/openvpn.ui f95e466
vpn/openvpn/openvpnadvanced.ui 24f7564
vpn/openvpn/openvpnadvancedwidget.cpp 1dea814
vpn/openvpn/openvpnauth.cpp c0d2a46
vpn/openvpn/openvpnwidget.cpp 5241883
vpn/pptp/pptpauth.ui e77a480
vpn/pptp/pptpprop.ui 33c1e86
vpn/pptp/pptpwidget.cpp dabaa25
vpn/ssh/sshauth.ui 1e4bf62
vpn/ssh/sshwidget.ui 95b4b6d
vpn/sstp/sstpadvanced.ui d198620
vpn/sstp/sstpauth.ui 2fad484
vpn/sstp/sstpwidget.cpp f0bf10a
vpn/sstp/sstpwidget.ui c4a0b42
vpn/strongswan/strongswanauth.ui d605290
vpn/strongswan/strongswanprop.ui 9ce7376
vpn/vpnc/vpnc.ui ab0ba36
vpn/vpnc/vpncauth.ui 22a3e4e
vpn/vpnc/vpncwidget.cpp 7c547f9
Diff: https://git.reviewboard.kde.org/r/129212/diff/
Testing
-------
Thanks,
Jan Grulich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20161020/bd855510/attachment-0001.html>
More information about the kde-networkmanager
mailing list