Review Request 129221: Minor improvements to the editor UI
Jan Grulich
jgrulich at redhat.com
Thu Oct 20 05:43:09 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129221/
-----------------------------------------------------------
(Updated Říj. 20, 2016, 5:43 dop.)
Review request for Network Management and Lamarque Souza.
Changes
-------
Fixes tooltips.
Images for comparison:
![IPv4 configuration - old](https://jgrulich.fedorapeople.org/editor/editor_ipv4_old.png)
![IPv4 configuration - new](https://jgrulich.fedorapeople.org/editor/editor_ipv4_new.png)
![Wifi configuration - old](https://jgrulich.fedorapeople.org/editor/editor_wifi_old.png)
![Wifi configuraiton - new](https://jgrulich.fedorapeople.org/editor/editor_wifi_new.png)
![Vpnc configuration - old](https://jgrulich.fedorapeople.org/editor/editor_vpnc_old.png)
![Vpnc configuration - new](https://jgrulich.fedorapeople.org/editor/editor_vpnc_new.png)
Repository: plasma-nm
Description
-------
+ vertical spacing between all widgets set to 6px (previously only few of them had this spacing)
+ checkbox alignment according to HIG
+ correct label alignment for some VPN widgets
Diffs (updated)
-----
libs/editor/settings/ipv4widget.cpp 2e92061
libs/editor/settings/ipv6widget.cpp c5fa3b8
libs/editor/settings/ui/802-1x.ui 54ae4fc
libs/editor/settings/ui/bond.ui 1c7d1c3
libs/editor/settings/ui/bridge.ui 61a1db6
libs/editor/settings/ui/bt.ui 295cd9e
libs/editor/settings/ui/cdma.ui bace7ce
libs/editor/settings/ui/infiniband.ui a3ab450
libs/editor/settings/ui/ipv4.ui 0aae15e
libs/editor/settings/ui/ipv6.ui 58d0c89
libs/editor/settings/ui/ppp.ui f53f38b
libs/editor/settings/ui/pppoe.ui bc6ee35
libs/editor/settings/ui/vlan.ui 1ea5bae
libs/editor/settings/ui/wificonnectionwidget.ui 283cff4
libs/editor/settings/ui/wifisecurity.ui 27610d0
libs/editor/settings/ui/wiredconnectionwidget.ui c07ae7f
vpn/iodine/iodine.ui ac92c17
vpn/l2tp/l2tp.ui 3dedc44
vpn/l2tp/l2tpadvanced.ui 80e333f
vpn/l2tp/l2tpauth.ui a5de7fe
vpn/l2tp/l2tpppp.ui 64ce2ac
vpn/openconnect/openconnectprop.ui ed7dfde
vpn/openswan/openswan.ui b5e107d
vpn/openswan/openswanauth.ui aa7f626
vpn/openvpn/openvpnadvanced.ui 24f7564
vpn/pptp/pptpadvanced.ui dd51bc7
vpn/pptp/pptpprop.ui 33c1e86
vpn/ssh/sshwidget.ui 95b4b6d
vpn/sstp/sstpadvanced.ui d198620
vpn/sstp/sstpwidget.ui c4a0b42
vpn/vpnc/vpnc.ui ab0ba36
vpn/vpnc/vpncadvanced.ui 9c27f85
Diff: https://git.reviewboard.kde.org/r/129221/diff/
Testing
-------
Thanks,
Jan Grulich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20161020/e88d6c85/attachment.html>
More information about the kde-networkmanager
mailing list