Review Request 129221: Minor improvements to the editor UI

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129221/#review100135
-----------------------------------------------------------



Well, I cannot see most of the changes now because I do not have time to recompile Plasma NM. If you can add screenshots of the changes would help me a low review the changes.


libs/editor/settings/ui/ipv6.ui (line 29)
<https://git.reviewboard.kde.org/r/129221/#comment67257>

    I think the "When connecting to IPv5-capable networks," is not needed. The "IPv4 configuration succeeds" part implies that this setting has effect only when IPv4 is enabled.



libs/editor/settings/ui/ipv6.ui (line 83)
<https://git.reviewboard.kde.org/r/129221/#comment67258>

    Edit list of domain name servers.



libs/editor/settings/ui/ipv6.ui (line 194)
<https://git.reviewboard.kde.org/r/129221/#comment67259>

    The ", on the other hand" part sounds strange. I think it can be omitted.



libs/editor/settings/ui/wificonnectionwidget.ui (line 130)
<https://git.reviewboard.kde.org/r/129221/#comment67256>

    This tooltip is not accurate. The wifi network is identified by the ssid and may comprise several access points. This option fixes one of those access points so the wifi card does not jump from one access point to another *in the same network*.
    
    As far as I know someone can have two or more access points in the same network (same ssid) with the same frequency band (same channel). This setting does not seem band specific to me, so the change "network associated to the specified band" does not seem accurate to me.



vpn/vpnc/vpncadvanced.ui (line 209)
<https://git.reviewboard.kde.org/r/129221/#comment67260>

    s/sets/set/


- Lamarque Souza


On Oct. 19, 2016, 11:03 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129221/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 11:03 a.m.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> + vertical spacing between all widgets set to 6px (previously only few of them had this spacing)
> + checkbox alignment according to HIG
> + correct label alignment for some VPN widgets
> 
> 
> Diffs
> -----
> 
>   libs/editor/settings/ipv4widget.cpp 2e92061 
>   libs/editor/settings/ipv6widget.cpp c5fa3b8 
>   libs/editor/settings/ui/802-1x.ui 54ae4fc 
>   libs/editor/settings/ui/bond.ui 1c7d1c3 
>   libs/editor/settings/ui/bridge.ui 61a1db6 
>   libs/editor/settings/ui/bt.ui 295cd9e 
>   libs/editor/settings/ui/cdma.ui bace7ce 
>   libs/editor/settings/ui/infiniband.ui a3ab450 
>   libs/editor/settings/ui/ipv4.ui 0aae15e 
>   libs/editor/settings/ui/ipv6.ui 58d0c89 
>   libs/editor/settings/ui/ppp.ui f53f38b 
>   libs/editor/settings/ui/pppoe.ui bc6ee35 
>   libs/editor/settings/ui/vlan.ui 1ea5bae 
>   libs/editor/settings/ui/wificonnectionwidget.ui 283cff4 
>   libs/editor/settings/ui/wifisecurity.ui 27610d0 
>   libs/editor/settings/ui/wiredconnectionwidget.ui c07ae7f 
>   vpn/iodine/iodine.ui ac92c17 
>   vpn/l2tp/l2tp.ui 3dedc44 
>   vpn/l2tp/l2tpadvanced.ui 80e333f 
>   vpn/l2tp/l2tpauth.ui a5de7fe 
>   vpn/l2tp/l2tpppp.ui 64ce2ac 
>   vpn/openconnect/openconnectprop.ui ed7dfde 
>   vpn/openswan/openswan.ui b5e107d 
>   vpn/openswan/openswanauth.ui aa7f626 
>   vpn/openvpn/openvpnadvanced.ui 24f7564 
>   vpn/pptp/pptpadvanced.ui dd51bc7 
>   vpn/pptp/pptpprop.ui 33c1e86 
>   vpn/ssh/sshwidget.ui 95b4b6d 
>   vpn/sstp/sstpadvanced.ui d198620 
>   vpn/sstp/sstpwidget.ui c4a0b42 
>   vpn/vpnc/vpnc.ui ab0ba36 
>   vpn/vpnc/vpncadvanced.ui 9c27f85 
> 
> Diff: https://git.reviewboard.kde.org/r/129221/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20161019/ecdc13ca/attachment.html>