Review Request 129111: Add Iodine VPN support

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129111/#review99910
-----------------------------------------------------------


Fix it, then Ship it!




Fix and ship it.


vpn/iodine/iodineauth.h (line 37)
<https://git.reviewboard.kde.org/r/129111/#comment67110>

    virtual is not needed here.


- Lamarque Souza


On Oct. 10, 2016, 6:22 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129111/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 6:22 a.m.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Bugs: 367655
>     http://bugs.kde.org/show_bug.cgi?id=367655
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This patch adds support for Iodine VPN connections allowing tunnel connections via DNS.
> 
> 
> Diffs
> -----
> 
>   vpn/CMakeLists.txt 3d3f962 
>   vpn/iodine/CMakeLists.txt PRE-CREATION 
>   vpn/iodine/Messages.sh PRE-CREATION 
>   vpn/iodine/iodine.h PRE-CREATION 
>   vpn/iodine/iodine.cpp PRE-CREATION 
>   vpn/iodine/iodine.ui PRE-CREATION 
>   vpn/iodine/iodineauth.h PRE-CREATION 
>   vpn/iodine/iodineauth.cpp PRE-CREATION 
>   vpn/iodine/iodineauth.ui PRE-CREATION 
>   vpn/iodine/iodinewidget.h PRE-CREATION 
>   vpn/iodine/iodinewidget.cpp PRE-CREATION 
>   vpn/iodine/nm-iodine-service.h PRE-CREATION 
>   vpn/iodine/plasmanetworkmanagement_iodineui.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20161010/fd830216/attachment.html>