Review Request 129111: Add Iodine VPN support

[Jan Grulich]

> On Říj. 6, 2016, 1:23 odp., Lamarque Souza wrote:
> > vpn/iodine/iodinewidget.cpp, line 140
> > <https://git.reviewboard.kde.org/r/129111/diff/1/?file=481768#file481768line140>
> >
> >     Only toplevelDomain is required? Shouldn't nameserver and password also be required? It does not make sense to create a vpn without password.

Yes, only toplevelDomain is required, the rest of properties are optional.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129111/#review99809
-----------------------------------------------------------


On Říj. 6, 2016, 11:09 dop., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129111/
> -----------------------------------------------------------
> 
> (Updated Říj. 6, 2016, 11:09 dop.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Bugs: 367655
>     http://bugs.kde.org/show_bug.cgi?id=367655
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This patch adds support for Iodine VPN connections allowing tunnel connections via DNS.
> 
> 
> Diffs
> -----
> 
>   vpn/CMakeLists.txt 3d3f962 
>   vpn/iodine/CMakeLists.txt PRE-CREATION 
>   vpn/iodine/Messages.sh PRE-CREATION 
>   vpn/iodine/iodine.h PRE-CREATION 
>   vpn/iodine/iodine.cpp PRE-CREATION 
>   vpn/iodine/iodine.ui PRE-CREATION 
>   vpn/iodine/iodineauth.h PRE-CREATION 
>   vpn/iodine/iodineauth.cpp PRE-CREATION 
>   vpn/iodine/iodineauth.ui PRE-CREATION 
>   vpn/iodine/iodinewidget.h PRE-CREATION 
>   vpn/iodine/iodinewidget.cpp PRE-CREATION 
>   vpn/iodine/nm-iodine-service.h PRE-CREATION 
>   vpn/iodine/plasmanetworkmanagement_iodineui.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20161006/9a2aa6e8/attachment-0001.html>