Review Request 129105: Add support for Juniper Openconnect VPN
Lamarque Souza
lamarque at kde.org
Wed Oct 5 12:54:44 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129105/#review99795
-----------------------------------------------------------
vpn/openconnect/openconnectwidget.cpp (line 112)
<https://git.reviewboard.kde.org/r/129105/#comment67075>
Remove leading space.
- Lamarque Souza
On Oct. 5, 2016, 10:39 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129105/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 10:39 a.m.)
>
>
> Review request for Network Management, David Woodhouse and Lamarque Souza.
>
>
> Bugs: 363917
> http://bugs.kde.org/show_bug.cgi?id=363917
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> This patch adds support for Juniper. It's added as a separate item in the menu by just adding one more desktop file for openconnect, while specifying subtype (anyconnect or juniper). Based on the subtype I set "protocol" property when creating a new openconnect connection.
>
>
> Diffs
> -----
>
> editor/connectioneditor.cpp 6e07971
> vpn/openconnect/CMakeLists.txt cb3fb18
> vpn/openconnect/nm-openconnect-service.h 4b45f20
> vpn/openconnect/openconnectwidget.cpp d94a9c7
> vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop PRE-CREATION
> vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop 6327344
>
> Diff: https://git.reviewboard.kde.org/r/129105/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20161005/b6d14d4f/attachment.html>
More information about the kde-networkmanager
mailing list