Review Request 128093: Make network manager version checks in runtime (to avoid compile vs. run-time discrepancies)

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128093/#review96219
-----------------------------------------------------------




src/CMakeLists.txt (line 54)
<https://git.reviewboard.kde.org/r/128093/#comment65025>

    I'm afraid that most of the new devices/settings won't compile against older NM versions as there are some NM macros used.



src/CMakeLists.txt (line 56)
<https://git.reviewboard.kde.org/r/128093/#comment65024>

    WiMAX needs to stay there, otherwise we would break the ABI compatibility again.



src/accesspoint.cpp (line 222)
<https://git.reviewboard.kde.org/r/128093/#comment65026>

    No need to check the version.



src/activeconnection.cpp (line 344)
<https://git.reviewboard.kde.org/r/128093/#comment65027>

    This should check for older NM version than 0.9.10 and not newer or equal.



src/activeconnection.cpp (line 364)
<https://git.reviewboard.kde.org/r/128093/#comment65028>

    I guess that this check is also not needed.



src/activeconnection.cpp (line 377)
<https://git.reviewboard.kde.org/r/128093/#comment65029>

    Same here.



src/activeconnection.cpp (line 390)
<https://git.reviewboard.kde.org/r/128093/#comment65030>

    Same here.



src/activeconnection.cpp (line 402)
<https://git.reviewboard.kde.org/r/128093/#comment65031>

    Same here.



src/activeconnection.cpp (line 414)
<https://git.reviewboard.kde.org/r/128093/#comment65032>

    Same here.



src/activeconnection.cpp (line 420)
<https://git.reviewboard.kde.org/r/128093/#comment65033>

    Same here.



src/device.cpp (line 335)
<https://git.reviewboard.kde.org/r/128093/#comment65034>

    No need for this check.



src/device.cpp (line 341)
<https://git.reviewboard.kde.org/r/128093/#comment65035>

    Same here.



src/device.cpp (line 347)
<https://git.reviewboard.kde.org/r/128093/#comment65036>

    Same here.



src/device.cpp (line 551)
<https://git.reviewboard.kde.org/r/128093/#comment65037>

    Coding style.


- Jan Grulich


On Čer. 6, 2016, 7:01 dop., Palo Kisa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128093/
> -----------------------------------------------------------
> 
> (Updated Čer. 6, 2016, 7:01 dop.)
> 
> 
> Review request for Network Management, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=362736
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 0470d8f 
>   src/accesspoint.h 51a1b2f 
>   src/accesspoint.cpp 62cbc6c 
>   src/accesspoint_p.h 521f8ce 
>   src/activeconnection.h 7516ad6 
>   src/activeconnection.cpp e833f51 
>   src/activeconnection_p.h 79a0055 
>   src/connection.h 5dd7a16 
>   src/connection.cpp 57c5aa0 
>   src/connection_p.h fb0b90b 
>   src/device.h f465f78 
>   src/device.cpp a3f6fad 
>   src/device_p.h 4d7bcb6 
>   src/ipconfig.h 24de6d2 
>   src/ipconfig.cpp d1316fc 
>   src/manager.h 0f36ba0 
>   src/manager.cpp bd8752c 
>   src/manager_p.h 8de789d 
>   src/settings.h 76cdd8d 
>   src/settings.cpp a15165f 
>   src/settings/bondsetting.cpp 3d52611 
>   src/settings/bridgesetting.cpp 05ce74c 
>   src/settings/connectionsettings.h 2dd00af 
>   src/settings/connectionsettings.cpp b62641e 
>   src/settings/connectionsettings_p.h d337c99 
>   src/settings/gsmsetting.cpp b13274b 
>   src/settings/infinibandsetting.h c0c854e 
>   src/settings/infinibandsetting.cpp 6ced9b1 
>   src/settings/infinibandsetting_p.h 238cd76 
>   src/settings/setting.cpp ba75623 
>   src/settings/teamsetting.cpp 60ff218 
>   src/settings/vlansetting.cpp 5c39dc9 
>   src/settings/wirelesssetting.cpp aa143c4 
>   src/settings_p.h aec5423 
>   src/vlandevice.h cec84ea 
>   src/vlandevice.cpp 029cab0 
>   src/vlandevice_p.h 83b6b6f 
>   src/wimaxdevice.cpp 468f50c 
>   src/wirelessdevice.h 65313a7 
>   src/wirelessdevice.cpp 9439606 
> 
> Diff: https://git.reviewboard.kde.org/r/128093/diff/
> 
> 
> Testing
> -------
> 
> It's a relatively big change... so everything needs to be double checked.
> 
> 
> File Attachments
> ----------------
> 
> 0001-Make-the-networkmanager-version-checks-in-runtime.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/54f5a458-701f-4590-b9b4-21ea0c04f682__0001-Make-the-networkmanager-version-checks-in-runtime.patch
> 
> 
> Thanks,
> 
> Palo Kisa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160606/ed5177f2/attachment-0001.html>