Review Request 128486: OpenVPN: add more choices to --comp-lzo option

Jan Grulich jgrulich at redhat.com
Tue Jul 19 14:53:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128486/
-----------------------------------------------------------

(Updated July 19, 2016, 2:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Lamarque Souza.


Changes
-------

Submitted with commit 31bcd5f2cffd1c19fbd10ab0f4172f2d82eff194 by Jan Grulich to branch master.


Bugs: 365816
    http://bugs.kde.org/show_bug.cgi?id=365816


Repository: plasma-nm


Description
-------

Since OpenVPN 2.1, the option --comp-lzo allows more choices then "yes" or "no" and we should handle that. See https://community.openvpn.net/openvpn/wiki/Openvpn23ManPage. Currently NetworkManager-openvpn supports that only in the plugin, but doesn't expose that in their UI which shouldn't be a problem.


Diffs
-----

  vpn/openvpn/openvpnadvanced.ui 9bfab83 
  vpn/openvpn/openvpnadvancedwidget.h 9fc2465 
  vpn/openvpn/openvpnadvancedwidget.cpp 3253e3b 

Diff: https://git.reviewboard.kde.org/r/128486/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160719/7d611f6d/attachment.html>


More information about the kde-networkmanager mailing list