Review Request 128707: Add support for captive portals

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98468
-----------------------------------------------------------




kded/portalmonitor.cpp (line 25)
<https://git.reviewboard.kde.org/r/128707/#comment66354>

    Nitpick: keep includes in lexicography order as much as possible.



kded/portalmonitor.cpp (line 44)
<https://git.reviewboard.kde.org/r/128707/#comment66353>

    You should delete m_view here in case this module is unloaded from kded5.



kded/portalmonitor.cpp (line 63)
<https://git.reviewboard.kde.org/r/128707/#comment66351>

    Missing watcher->deleteLater()



kded/portalmonitor.cpp (line 64)
<https://git.reviewboard.kde.org/r/128707/#comment66352>

    You should check if reply returned error or this line can lead to crash in that case.


- Lamarque Souza


On Aug. 18, 2016, 11:42 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2016, 11:42 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.
> 
> 
> Bugs: 365417
>     http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> -------
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160818/7c9b3538/attachment.html>