Review Request 128332: [Plasma-nm] Indicate flight mode in system tray icon

Mon Aug 1 15:47:31 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------

(Updated Aug. 1, 2016, 3:47 p.m.)

Status
------

This change has been marked as submitted.

Review request for Network Management, Plasma and KDE Usability.

Changes
-------

Submitted with commit 2d0150fc72981b27712ee80590d4b2741626e317 by Kai Uwe Broulik to branch master.

Repository: plasma-nm

Description
-------

This changes the tray icon to the airplane icon when in flight mode.

Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.

BUG: 364626

Diffs
-----

  applet/contents/ui/SwitchButton.qml 3ea3079 
  applet/contents/ui/Toolbar.qml 64b6e0a 
  libs/declarative/connectionicon.h 499b4f6 
  libs/declarative/connectionicon.cpp 90060a3 

Diff: https://git.reviewboard.kde.org/r/128332/diff/

Testing
-------

Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.

The flight mode is only shown when flight mode is enabled and there really isn't any connection.

NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.

File Attachments
----------------

Flightmode icon
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160801/94832f8d/attachment.html>