Review Request 125356: Add some advanced validation for WPA/WPA2 Enterprise

Jan Grulich jgrulich at redhat.com
Wed Sep 23 13:14:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125356/
-----------------------------------------------------------

(Updated Sept. 23, 2015, 1:14 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Lamarque Souza.


Changes
-------

Submitted with commit edc29fb7ca7c9610156bfe571c4bcec2cef44be4 by Jan Grulich to branch master.


Bugs: 351191
    http://bugs.kde.org/show_bug.cgi?id=351191


Repository: plasma-nm


Description
-------

This patch adds dependency on QCA which is used for validation of private key in TLS EAP method. It now checks whether the private key is in PKCS12 format and if can be decrypted with given private key password. If it's in PKCS12 format, the same path for the private key is also set as the client certificate path, because it's bundled with the private key (BUG 351191). If the private key is PEM file (.pem, .key) it just checks whether the private key can be decrypted with given private key password. I didn't find out the way how to open private keys in DER format yet, but I read that it's mostly used in Windows anyway. Also, if the private key is not in PKCS12 format, we also have to check whether the client certificate is set.


Diffs
-----

  CMakeLists.txt 5d00936 
  libs/editor/CMakeLists.txt facc5e5 
  libs/editor/settings/security802-1x.cpp 88cbf36 
  libs/editor/settings/ui/802-1x.ui 525c644 

Diff: https://git.reviewboard.kde.org/r/125356/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150923/d9813126/attachment.html>


More information about the kde-networkmanager mailing list