Review Request 125281: Add WPA/WPA2 Enterprise (partial) validation + options to add subjectMatch and altSubjectMatch properties

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125281/#review85620
-----------------------------------------------------------



libs/editor/listvalidator.cpp (line 43)
<https://git.reviewboard.kde.org/r/125281/#comment59162>

    ++i intead of i++



libs/editor/listvalidator.cpp (line 47)
<https://git.reviewboard.kde.org/r/125281/#comment59163>

    const



libs/editor/listvalidator.cpp (line 61)
<https://git.reviewboard.kde.org/r/125281/#comment59161>

    QLatin1Char(',')



libs/editor/settings/security802-1x.cpp (line 83)
<https://git.reviewboard.kde.org/r/125281/#comment59168>

    According to [1] scheme does not allow underscore  character (_) but allows minus (-) and plus (+). There should be double slash after the scheme.
    
    [1] https://tools.ietf.org/html/rfc3986#section-3.1



libs/editor/settings/security802-1x.cpp (line 244)
<https://git.reviewboard.kde.org/r/125281/#comment59164>

    const



libs/editor/widgets/editlistdialog.h (line 34)
<https://git.reviewboard.kde.org/r/125281/#comment59165>

    nullptr instead of 0.



libs/editor/widgets/editlistdialog.cpp (line 86)
<https://git.reviewboard.kde.org/r/125281/#comment59167>

    Code style: remove space after *


- Lamarque Souza


On Sept. 18, 2015, 10:31 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125281/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 10:31 a.m.)
> 
> 
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Bugs: 342728
>     http://bugs.kde.org/show_bug.cgi?id=342728
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> 1) Adds options to set subjectMatch and altSubjectMatch properties (taken from the old NM applet)
>    - bug 342728 - Security bug/Regression: altSubjectMatch disappeared with the move to plasma-nm
> 
> 2) Adds WPA/WPA2 Enterprise validation (done according to nm-connection-editor). It's not complete for TLS, I found out that we need to also check private key and get its format to know whether we need client certificate or not, because it might be set already by private key if it's in NM_SETTING_802_1X_CK_FORMAT_PKCS12 format. I would need more time to implement this and verify if I implemented it correctly so that's why I'm sending this part to review first. This should also fix bug 351191 where I think that the problem is that we don't set client certificate if private key is in NM_SETTING_802_1X_CK_FORMAT_PKCS12 format.
> 
> 
> Diffs
> -----
> 
>   libs/editor/CMakeLists.txt 22b7eca 
>   libs/editor/listvalidator.h PRE-CREATION 
>   libs/editor/listvalidator.cpp PRE-CREATION 
>   libs/editor/settings/security802-1x.h 22c78fa 
>   libs/editor/settings/security802-1x.cpp 0f8f71d 
>   libs/editor/settings/ui/802-1x.ui ac5732a 
>   libs/editor/settings/wifisecurity.cpp b2b80fb 
>   libs/editor/widgets/editlistdialog.h PRE-CREATION 
>   libs/editor/widgets/editlistdialog.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125281/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150918/98bf4f7e/attachment.html>