Review Request 125785: Make all bluez calls asynchronous

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125785/#review87369
-----------------------------------------------------------

Ship it!


beautiful.


libs/handler.cpp (line 338)
<https://git.reviewboard.kde.org/r/125785/#comment59995>

    no point capturing eanbled, we know it's going to be false.



libs/handler.cpp (line 339)
<https://git.reviewboard.kde.org/r/125785/#comment59994>

    this watcher (getWatcher from 336) leaks


- David Edmundson


On Oct. 25, 2015, 1:53 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125785/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2015, 1:53 p.m.)
> 
> 
> Review request for Network Management, David Edmundson and Lamarque Souza.
> 
> 
> Bugs: 354230
>     http://bugs.kde.org/show_bug.cgi?id=354230
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This is a quick patch to address bug 354230. I don't know why this started happening on Kubuntu 15.10, I even tried to install it but couldn't reproduce. Anyway, this patch makes all bluez call asynchronous (at least I hope so). The only thing missing is that it now doesn't remember previous state of bluetooth adapter so if it's initially disabled and you turn on and then turn off the airplane mode, it will enable also all bluetooth adapters even when it shouldn't. Given that the bug is quite annoying and I don't want to spend sunday behind computer I would say that the new introduced issue is not that important and can be addressed later.
> 
> 
> Diffs
> -----
> 
>   libs/handler.h ceedab9 
>   libs/handler.cpp 901230d 
> 
> Diff: https://git.reviewboard.kde.org/r/125785/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151025/ec5ccfff/attachment-0001.html>